Merge commit 4cfa3f4 from libjpeg-turbo #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix negative shift with IFAST FDCT and qual=100 With certain images, compressing using quality=100 and the fast integer forward DCT will cause the divisor passed to compute_reciprocal() to be 1. In those cases, the library already disables the SIMD quantization algorithm to avoid 16-bit overflow. However, compute_reciprocal() doesn't properly handle the divisor==1 case, so we need to use special values in that case so that the C quantization algorithm will behave like an identity function.
|
Has this fix been applied upstream? Now that libjpeg-turbo uses git I think mozjpeg can merge whole libjpeg-turbo releases instead of cherry-picking commits. |
|
Yes, here: libjpeg-turbo/libjpeg-turbo@4cfa3f4. It should end up in libjpeg-turbo 1.4.2, eventually. |
|
OK, I'll work on merging that with the rest of the branch soon. |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Sep 13, 2015
This fixes regression tests with clang 3.7.0 PR: 202763 Obtained from: libjpeg-turbo/libjpeg-turbo@4cfa3f4 Submitted upstream in: mozilla/mozjpeg#186 Approved by: maintainer timeout (2 weeks) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@396859 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Sep 13, 2015
This fixes regression tests with clang 3.7.0 PR: 202763 Obtained from: libjpeg-turbo/libjpeg-turbo@4cfa3f4 Submitted upstream in: mozilla/mozjpeg#186 Approved by: maintainer timeout (2 weeks)
felixbuenemann
added a commit
to felixbuenemann/homebrew-core
that referenced
this pull request
Apr 24, 2016
This adds 64-bit assembly fixes for mozilla/mozjpeg/issues/202 and a fix for corruption with qual=100 from mozilla/mozjpeg/pull/186. Both fixes have been in libjpeg-turbo, which mozjpeg is based on for a long time and have been approved by mozjpeg's pornel for inclusion in a future mozjpeg release. See the linked issue / pull request for more info. The revision bump is because this fixes crashes for existing installs.
|
I think we should close this and we'll just take the fix when we merge from upstream. v1.5.0 of libjpeg-turbo should be out mid-June, I think we should just move to that. |
apjanke
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 22, 2016
This adds 64-bit assembly fixes for mozilla/mozjpeg/issues/202 and a fix for corruption with qual=100 from mozilla/mozjpeg/pull/186. Both fixes have been in libjpeg-turbo, which mozjpeg is based on for a long time and have been approved by mozjpeg's pornel for inclusion in a future mozjpeg release. See the linked issue / pull request for more info. The revision bump is because this fixes crashes for existing installs. Closes #564. Signed-off-by: Andrew Janke <janke@eilonwy.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes undefined behavior in jcdctmgr.c's quantize() function, as reported in libjpeg-turbo/libjpeg-turbo#13: