Skip to content
This repository has been archived by the owner on May 15, 2018. It is now read-only.

Updated notification emails to contain full application and platform details. Fixes #75 #122

Closed
wants to merge 2 commits into from

Conversation

davehunt
Copy link
Member

@davehunt davehunt commented Jul 5, 2012

Uses a snapshot version of the email-ext plugin that includes a necessary fix.

@whimboo
Copy link
Contributor

whimboo commented Jul 6, 2012

I think we need the .jpi package of the snapshot only, right? Also can you post an example how the summary and the body looks like with that patch?

@davehunt
Copy link
Member Author

davehunt commented Jul 6, 2012

The snapshot is included. It's a .hpi, but that makes no difference.

Subject:

[Successful] mozilla-aurora_addons: Firefox 15.0a2 en-US on Mac OS X 10.7.4 64bit (20120702042008)

Body:

Mozmill mozilla-aurora_addons testrun for Firefox 15.0a2 en-US on Mac OS X 10.7.4 64bit (20120702042008) completed with 0 failures.

View the build in Jenkins:
http://localhost:8080/job/mozilla-aurora_addons/12/

View the results in the Mozmill Dashboard:
http://mozmill-crowd.blargon7.com/#/addons/report/4c461f9adf1253771fc64556671b2e68

@whimboo
Copy link
Contributor

whimboo commented Jul 10, 2012

The snapshot is included. It's a .hpi, but that makes no difference.

Well, there is the email-ext.jpi and email-ext.hpi included. Please use only the right one.

@davehunt
Copy link
Member Author

Nope, email-ext.jpi has been removed and email-ext.hpi has been added. It's all in this pull.

@whimboo
Copy link
Contributor

whimboo commented Jul 10, 2012

diff stats were hidden so I missed that. Sorry. So yes, looks fine now. Please get it landed.

@davehunt
Copy link
Member Author

According to the developer, the official release of the new plugin version will be today or tomorrow so let's hold off.

@whimboo
Copy link
Contributor

whimboo commented Jul 24, 2012

Dave, can we now continue? Has it been released?

@davehunt
Copy link
Member Author

Yep, it was finally released a few days ago. I will add this to my list.

On 24 July 2012 09:13, Henrik Skupin <
reply@reply.github.com

wrote:

Dave, can we now continue? Has it been released?


Reply to this email directly or view it on GitHub:
#122 (comment)

Dave Hunt

@davehunt
Copy link
Member Author

Updated, ready for final review/merge.

@whimboo
Copy link
Contributor

whimboo commented Jul 24, 2012

Looks fine to me. I assume you have tested this. Feel free to get it landed.

@whimboo
Copy link
Contributor

whimboo commented Jul 25, 2012

This has already been landed as:
f0e7703

@whimboo whimboo closed this Jul 25, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants