Skip to content
This repository has been archived by the owner on May 15, 2018. It is now read-only.

Only run endurance tests on nodes with the 'endurance' label. Fixes issue #173 #200

Closed
wants to merge 2 commits into from

Conversation

davehunt
Copy link
Member

@davehunt davehunt commented Feb 1, 2013

This pull adds script/testrun specific node allocation for Mozmill CI, initially only endurance takes advantage of this, however it could easily be expanded in the future.

I have done limited testing for this, and would propose that we look to test this thoroughly on staging before we push to production.

@@ -65,6 +65,9 @@ def main():
continue

for locale in locales:
if script in ['endurance']:
node_labels.append(script)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do that for each locale right? Otherwise we would end-up with [windows, xp, 32bit, endurance, endurance...].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Thanks for spotting that.

@whimboo
Copy link
Contributor

whimboo commented Feb 3, 2013

Looks fine otherwise.

@davehunt
Copy link
Member Author

davehunt commented Feb 4, 2013

Updated. Thanks @whimboo

@whimboo
Copy link
Contributor

whimboo commented Feb 4, 2013

Looks good to me now. Have you tested it locally? If it works fine we can merge and also push it to staging for further testing.

@davehunt
Copy link
Member Author

davehunt commented Feb 4, 2013

It works locally for triggering ondemand but I haven't tested with pulse...
I was thinking that we could do this testing much more efficiently on
staging. Let me know what you think.

On 4 February 2013 14:49, Henrik Skupin notifications@github.com wrote:

Looks good to me now. Have you tested it locally? If it works fine we can
merge and also push it to staging for further testing.


Reply to this email directly or view it on GitHubhttps://github.com//pull/200#issuecomment-13079947.

Dave Hunt

@whimboo
Copy link
Contributor

whimboo commented Feb 4, 2013

Ok, so lets get this to staging then and test there. Can you cover that work?

@davehunt
Copy link
Member Author

davehunt commented Feb 5, 2013

Landed in commit e3f81ee

@davehunt davehunt closed this Feb 5, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants