Skip to content
This repository has been archived by the owner on May 15, 2018. It is now read-only.

Add Ubuntu 14.10 machines (#541) #542

Closed
wants to merge 3 commits into from
Closed

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Dec 19, 2014

This PR fixes issue #541. @andreeamatei if you still have a bit of time today, I would appreciate a review on that. So we can get the new machines connected on staging for the weekend.

@andreeamatei
Copy link
Contributor

Looks good. Just a question, we're keeping 13.10 in the config files still, to make sure all is good with 14.10 before removing them, but in the patches for staging/producion, we already replaced them. Is this intended? I looked over how we did this for 14.04.

@whimboo
Copy link
Contributor Author

whimboo commented Dec 19, 2014

Ups, you are right! :) What would you prefer? I'm happy to replace it completely with this PR, and not keep the old ones.

@andreeamatei
Copy link
Contributor

We could, with 14.04 we didn't had issues with the tests, there was only a thing with the nodes settings. Should work fine to remove them now, we'll get there eventually anyway.

@whimboo
Copy link
Contributor Author

whimboo commented Dec 19, 2014

Ok, I pushed two more commits which completely get rid of old versions. I even found a 12.04 reference to be still existent in the Jenkins config! I cleared them all now.

@andreeamatei
Copy link
Contributor

LGTM now.

@whimboo
Copy link
Contributor Author

whimboo commented Dec 22, 2014

Merged PR as edce136.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants