Bug 1134984 - getApplicationDetails() fails because of non-serializable objects. r=dhunt

whimboo · whimboo · commit 6c0948d80eeb · 2015-02-20T12:10:41.000+01:00
diff --git a/mozmill/mozmill/extension/resource/driver/mozmill.js b/mozmill/mozmill/extension/resource/driver/mozmill.js
@@ -72,21 +72,17 @@ var Application = utils.applicationName;
  */
 function getAddons() {
   var addons = null;
+  var keys = ["id", "isActive", "isCompatible", "name", "type", "version"];
 
   AddonManager.getAllAddons(function (addonList) {
     var tmp_list = [ ];
 
     addonList.forEach(function (addon) {
       var tmp = { };
 
-      // We have to filter out properties of type 'function' of the addon
-      // object, which will break JSON.stringify() and result in incomplete
-      // addon information.
-      for (var key in addon) {
-        if (typeof(addon[key]) !== "function") {
-          tmp[key] = addon[key];
-        }
-      }
+      keys.forEach(function (key) {
+        tmp[key] = addon[key];
+      });
 
       tmp_list.push(tmp);
     });
