Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter key no longer works on "Open this site in your assigned Container?" page #2214

Closed
Exagone313 opened this issue Nov 25, 2021 · 1 comment · Fixed by #2215
Closed

Enter key no longer works on "Open this site in your assigned Container?" page #2214

Exagone313 opened this issue Nov 25, 2021 · 1 comment · Fixed by #2215

Comments

@Exagone313
Copy link
Contributor

Exagone313 commented Nov 25, 2021

  • Multi-Account Containers Version: 8.0.2
  • Operating System + Version: Arch Linux
  • Firefox Version: 94.0
  • Other installed Add-ons + Version + Enabled/Disabled-Status: not relevant

Actual behavior

When a website is configured to open in a particular container, but the decision has not been remembered, it shows the Open this site in your assigned Container? page.

When pressing the enter key, it doesn't validate the button Open in <selected container> Container

Actually the button is not focused:

21-11-25-18-10-15-716528312

Expected behavior

When pressing the enter key, it should open the website in the selected container.

The button is expected to be focused:

21-11-25-18-08-21-107753020

Steps to reproduce

  1. Assign a website to container
  2. Open a new tab and visit the website
  3. On the Open this site in your assigned Container? page, press enter.

Notes

This is a regression from the version 8.0.1, which is in fact the 7.x version:

Version 8.0.1
Released Nov 2, 2021 - 178.47 KB
Works with firefox 67.0 and later
Restoring previous version for some users who may have been accidentally updated prematurely 8.0.

The autofocus attribute of the button attribute has been removed in commit 05dc48e:

-        <button id="deny" class="button">Open in <dfn id="current-container-name">Current</dfn> Container</button>
-        <button id="confirm" class="button primary" autofocus>Open in <dfn class="container-name"></dfn> Container</button>
+        <button id="deny" class="button" data-message-id="openInContainer" data-message-arg="current-container-name"></button>
+        <button id="confirm" class="button primary" data-message-id="openInContainer" data-message-arg="container-name"></button>

I'm working on a PR.

Exagone313 added a commit to Exagone313/multi-account-containers that referenced this issue Nov 25, 2021
This is a regression introduced in commit:
05dc48e

The autofocus attribute was removed unexpectedly in a localization
change.
Exagone313 added a commit to Exagone313/multi-account-containers that referenced this issue Nov 25, 2021
This is a regression introduced in commit:
05dc48e

The autofocus attribute was removed unexpectedly in a localization
change.
@nabeelr
Copy link

nabeelr commented Nov 25, 2021

I'd like to add fuel tho this fire. This is really annoying and should be corrected.
The highlighted button is always expected to be the action when a person hits the enter key. That not happening breaks UI convention going back more than 40 years.

bakulf pushed a commit that referenced this issue Nov 30, 2021
This is a regression introduced in commit:
05dc48e

The autofocus attribute was removed unexpectedly in a localization
change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants