Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically focus confirm button on confirm page #2215

Merged
merged 1 commit into from Nov 28, 2021

Conversation

Exagone313
Copy link
Contributor

@Exagone313 Exagone313 commented Nov 25, 2021

Fixes #2214

This is a regression introduced in commit:
05dc48e

The autofocus attribute was removed unexpectedly in a localization
change.

This is a regression introduced in commit:
05dc48e

The autofocus attribute was removed unexpectedly in a localization
change.
@Exagone313
Copy link
Contributor Author

Exagone313 commented Nov 25, 2021

Additional information:

I had this error when loading the extension locally:

Extension is invalid
Loading locale file _locales/.github/messages.json: Error: Error while loading 'file:///home/exagone/Git/multi-account-containers/src/_locales/.github/messages.json' (NS_ERROR_FILE_NOT_FOUND)

Same with web-ext (without verbosity):

o: installTemporaryAddon: Error: Error: Could not install add-on at '/home/exagone/Git/multi-account-containers/src': Error: Extension is invalid

Temporarily fixed it by adding a symlink from .github to en. I don't know if it's a bug related to my environment or not.

So I tested and it works.

@Exagone313 Exagone313 changed the title Automatically focus confirm button on confirm page (#2214) Automatically focus confirm button on confirm page Nov 25, 2021
Copy link

@danielfilho danielfilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forked the repo to reintroduce this feature and before opening a pull request, I found this. I do extensive use of this add-on and it's really getting into my head that this property was removed.

Thank you for the contribution 👍

@Exagone313
Copy link
Contributor Author

I have held updating this addon on all my systems/profiles until this is merged and published. This disrupts my workflow too much.

@groovecoder
Copy link
Member

Thanks! Running workflow to check and will merge and set up a release.

Copy link
Member

@groovecoder groovecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-check and code looks good.

@groovecoder groovecoder merged commit ac98046 into mozilla:main Nov 28, 2021
@groovecoder groovecoder mentioned this pull request Nov 28, 2021
@danielfilho
Copy link

Thanks for merging it @groovecoder, this is really nice. And thank you for all the effort on this project.

Just to calm down my anxiety, do you know what's the next step for the release? I take a look at the releases and it happens with quite a few months between them. Is there anything we can do to help on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter key no longer works on "Open this site in your assigned Container?" page
3 participants