New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically focus confirm button on confirm page #2215
Automatically focus confirm button on confirm page #2215
Conversation
This is a regression introduced in commit: 05dc48e The autofocus attribute was removed unexpectedly in a localization change.
Additional information: I had this error when loading the extension locally:
Same with web-ext (without verbosity):
Temporarily fixed it by adding a symlink from So I tested and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forked the repo to reintroduce this feature and before opening a pull request, I found this. I do extensive use of this add-on and it's really getting into my head that this property was removed.
Thank you for the contribution 👍
I have held updating this addon on all my systems/profiles until this is merged and published. This disrupts my workflow too much. |
Thanks! Running workflow to check and will merge and set up a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot-check and code looks good.
Thanks for merging it @groovecoder, this is really nice. And thank you for all the effort on this project. Just to calm down my anxiety, do you know what's the next step for the release? I take a look at the releases and it happens with quite a few months between them. Is there anything we can do to help on this? |
Fixes #2214
This is a regression introduced in commit:
05dc48e
The autofocus attribute was removed unexpectedly in a localization
change.