New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container options flashes up when hovering + (new tab) button, I'd prefer Long Press #331

Closed
jnachtigall opened this Issue Mar 3, 2017 · 14 comments

Comments

Projects
None yet
6 participants
@jnachtigall

jnachtigall commented Mar 3, 2017

As reported at discourse. I find it find annoying that the Containers always flash up when hovering the + (new tab) button. I'd prefer long press for it to show up.

container

I do not want anybody looking over my shoulder to see "Personal", "Shopping" options, especially at work. Because people might go: Whoo, what's this? And might think I'm doing private stuff at work. I found this so essential that I disabled it again.

It's like somebody seeing in Private Mode at work, then people also always ask: What is she/he doing? Delicate privacy issues.

@smichel17

This comment has been minimized.

Show comment
Hide comment
@smichel17

smichel17 Mar 3, 2017

I'm in somewhat the opposite boat. I prefer the block-shaped UI of the Containers button (specifically, I don't like having unresponsive space between the buttons), but I use the new tab button because I like the pop-up.

Would it be a reasonable compromise, if there were a pop-up, but it only showed the icons (like what appears to the left when you hover over a category in the containers menu)? In this case maybe expanding horizontally instead of vertically would make sense.

That way people in my boat can keep the pop-up, but your privacy is preserved, especially if you set all the icons to the circle, so the pop up is just a bunch of colored circles with + signs.

smichel17 commented Mar 3, 2017

I'm in somewhat the opposite boat. I prefer the block-shaped UI of the Containers button (specifically, I don't like having unresponsive space between the buttons), but I use the new tab button because I like the pop-up.

Would it be a reasonable compromise, if there were a pop-up, but it only showed the icons (like what appears to the left when you hover over a category in the containers menu)? In this case maybe expanding horizontally instead of vertically would make sense.

That way people in my boat can keep the pop-up, but your privacy is preserved, especially if you set all the icons to the circle, so the pop up is just a bunch of colored circles with + signs.

@jnachtigall

This comment has been minimized.

Show comment
Hide comment
@jnachtigall

jnachtigall Mar 4, 2017

@smichel17 My concern was not about block-shape, icons or horizontal vs. vertical. I was about the falshing up immediately. I'd prefered if it did not always turn up, but only on long press. Please reread my above post and also what I've written at discourse.

jnachtigall commented Mar 4, 2017

@smichel17 My concern was not about block-shape, icons or horizontal vs. vertical. I was about the falshing up immediately. I'd prefered if it did not always turn up, but only on long press. Please reread my above post and also what I've written at discourse.

@smichel17

This comment has been minimized.

Show comment
Hide comment
@smichel17

smichel17 Mar 4, 2017

I think you misread mine. I probably should have emphasized this part:

I use the new tab button because I like the pop-up.

smichel17 commented Mar 4, 2017

I think you misread mine. I probably should have emphasized this part:

I use the new tab button because I like the pop-up.

@jnachtigall

This comment has been minimized.

Show comment
Hide comment
@jnachtigall

jnachtigall Mar 4, 2017

@smichel17 Sorry if I've misread. I had little time when I wrote the first reply and it might come over a bit harsh. Sorry about that.

Anyway, maybe there could be a setting for this, say, radio button with two options:
(o) Show options on hover
(o) Show options on long press

Just an idea, sure it is hard to please everybody.

To answer your question:

Would it be a reasonable compromise, if there were a pop-up, but it only showed the icons (like what appears to the left when you hover over a category in the containers menu)?

Not really, this would only be a minor improvement from my point of view as it is still visible (privacy concerns - I'd like to able to hide this).

Of course, once Containers are well known, this current concerns would diminish because they would not be that suspicious any more.

jnachtigall commented Mar 4, 2017

@smichel17 Sorry if I've misread. I had little time when I wrote the first reply and it might come over a bit harsh. Sorry about that.

Anyway, maybe there could be a setting for this, say, radio button with two options:
(o) Show options on hover
(o) Show options on long press

Just an idea, sure it is hard to please everybody.

To answer your question:

Would it be a reasonable compromise, if there were a pop-up, but it only showed the icons (like what appears to the left when you hover over a category in the containers menu)?

Not really, this would only be a minor improvement from my point of view as it is still visible (privacy concerns - I'd like to able to hide this).

Of course, once Containers are well known, this current concerns would diminish because they would not be that suspicious any more.

@smichel17

This comment has been minimized.

Show comment
Hide comment
@smichel17

smichel17 Mar 4, 2017

Not really, this would only be a minor improvement from my point of view as it is still visible (privacy concerns - I'd like to able to hide this).

I don't quite follow this. If you make all your icons circles, then the pop-up would only be a bunch of colored circles. And, if someone also sees your colored tabs (which they would, since, there's no way to hide it), it's pretty quickly obvious that the colors in the pop-up are related to those on the tabs.

So to me, that seems roughly equal in suspicion level to the tabs being highlighted in different colors in the first place. If I saw someone's tabs highlighted in different colors without knowing what it was, I'd assume it's just a way to organize tabs -- not very suspicious, in my opinion. (maybe you disagree?)

smichel17 commented Mar 4, 2017

Not really, this would only be a minor improvement from my point of view as it is still visible (privacy concerns - I'd like to able to hide this).

I don't quite follow this. If you make all your icons circles, then the pop-up would only be a bunch of colored circles. And, if someone also sees your colored tabs (which they would, since, there's no way to hide it), it's pretty quickly obvious that the colors in the pop-up are related to those on the tabs.

So to me, that seems roughly equal in suspicion level to the tabs being highlighted in different colors in the first place. If I saw someone's tabs highlighted in different colors without knowing what it was, I'd assume it's just a way to organize tabs -- not very suspicious, in my opinion. (maybe you disagree?)

@jnachtigall

This comment has been minimized.

Show comment
Hide comment
@jnachtigall

jnachtigall Mar 5, 2017

I don't quite follow this. If you make all your icons circles, then the pop-up would only be a bunch of colored circles.

They would not see at all if it would not flash up immediately on hover, but only on looong left-mouse press. There's a distinction between seeing not at all and seeing just some icons. But I agree that showing only the icons – without "Personal", "Work", "Shopping" – would also be less suspicious

And, if someone also sees your colored tabs (which they would, since, there's no way to hide it)

I would hide them and only unhide if it is save to do so (alone in a room) with:
auswahl_071

Eventually, there should be a shortcut for hide/unhide. I'll open a ticket for this for discussion.

But again: My concerns would diminish when Containers are more popular and other people know about the popup flashing up. So maybe just take this feedback and let's see what other users think.

jnachtigall commented Mar 5, 2017

I don't quite follow this. If you make all your icons circles, then the pop-up would only be a bunch of colored circles.

They would not see at all if it would not flash up immediately on hover, but only on looong left-mouse press. There's a distinction between seeing not at all and seeing just some icons. But I agree that showing only the icons – without "Personal", "Work", "Shopping" – would also be less suspicious

And, if someone also sees your colored tabs (which they would, since, there's no way to hide it)

I would hide them and only unhide if it is save to do so (alone in a room) with:
auswahl_071

Eventually, there should be a shortcut for hide/unhide. I'll open a ticket for this for discussion.

But again: My concerns would diminish when Containers are more popular and other people know about the popup flashing up. So maybe just take this feedback and let's see what other users think.

@jnachtigall

This comment has been minimized.

Show comment
Hide comment
@jnachtigall

jnachtigall Mar 9, 2017

I've found an easy solution to my problem. It's so easy it is strange that I did not think of it earlier: I just renamed, changed the icon or deleted the inappropriate "Personal", "Shopping", "Work" things to something more appropriate and less suspicious or "misguiding".

So I think the flashing popup is not a bad UX actually (Facebook has the same for its like buttons). Long press would probably have discoverability problems.

Mozilla devs: You can close if you want. I'll leave it open for now in case you want to consider this use case / feedback.

Maybe a better approach would be to offer the users different sets of predefined container definitions. For me, the default did not work. A simple "Container 1" and "Container 2" and an easy guided tour to change them at the beginning would have been better. Just some ideas ;)

jnachtigall commented Mar 9, 2017

I've found an easy solution to my problem. It's so easy it is strange that I did not think of it earlier: I just renamed, changed the icon or deleted the inappropriate "Personal", "Shopping", "Work" things to something more appropriate and less suspicious or "misguiding".

So I think the flashing popup is not a bad UX actually (Facebook has the same for its like buttons). Long press would probably have discoverability problems.

Mozilla devs: You can close if you want. I'll leave it open for now in case you want to consider this use case / feedback.

Maybe a better approach would be to offer the users different sets of predefined container definitions. For me, the default did not work. A simple "Container 1" and "Container 2" and an easy guided tour to change them at the beginning would have been better. Just some ideas ;)

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Mar 9, 2017

Member

I'm going to close this for now since we don't plan to actively work on it.

If we get many more 👍 and/or comments on this issue, we may re-open it.

Thanks for the feedback.

Member

groovecoder commented Mar 9, 2017

I'm going to close this for now since we don't plan to actively work on it.

If we get many more 👍 and/or comments on this issue, we may re-open it.

Thanks for the feedback.

@groovecoder groovecoder closed this Mar 9, 2017

@jjnilton

This comment has been minimized.

Show comment
Hide comment
@jjnilton

jjnilton Apr 18, 2017

I think the way it works on Nightly (54.0a2) is better and less intrusive, not exactly for the same reason as @jnachtigall, but I just don't think I need to see the containers list every time I'm hovering the new tab button. It's annoying to see the container list every time I'm going to open a new tab or I hover cursor, maybe going to close the last tab or clicking on a button in the toolbar.

I don't use the Containers feature very much when I'm not working, so I don't see the need to see the list of my containers all the time but when I'm working and I may use containers a bit more, I can see that hovering the "+" button to show it can be handy, even then I'd like to trigger it manually.

An option to choose if the container list will show up by hovering/long pressing or different key bind (maybe something that would show the list with the keyboard and allow selecting the container with the keyboard) could solve this.

This is my use case, maybe it could come with the option to trigger by hovering by default, but having the option to set it to show only by long pressing or pressing some key combination.

jjnilton commented Apr 18, 2017

I think the way it works on Nightly (54.0a2) is better and less intrusive, not exactly for the same reason as @jnachtigall, but I just don't think I need to see the containers list every time I'm hovering the new tab button. It's annoying to see the container list every time I'm going to open a new tab or I hover cursor, maybe going to close the last tab or clicking on a button in the toolbar.

I don't use the Containers feature very much when I'm not working, so I don't see the need to see the list of my containers all the time but when I'm working and I may use containers a bit more, I can see that hovering the "+" button to show it can be handy, even then I'd like to trigger it manually.

An option to choose if the container list will show up by hovering/long pressing or different key bind (maybe something that would show the list with the keyboard and allow selecting the container with the keyboard) could solve this.

This is my use case, maybe it could come with the option to trigger by hovering by default, but having the option to set it to show only by long pressing or pressing some key combination.

@deimidis

This comment has been minimized.

Show comment
Hide comment
@deimidis

deimidis Jul 16, 2017

I just notice that you implent this. I begun to search because I was so used to have the option when I hover new tab, that was annpying not find that option with the change.

Is there any way to find news about updates like this? I was hoping it was a problem with nightly, not a new way to open tabs in containers

deimidis commented Jul 16, 2017

I just notice that you implent this. I begun to search because I was so used to have the option when I hover new tab, that was annpying not find that option with the change.

Is there any way to find news about updates like this? I was hoping it was a problem with nightly, not a new way to open tabs in containers

@jonathanKingston

This comment has been minimized.

Show comment
Hide comment
@jonathanKingston

jonathanKingston Jul 17, 2017

Member
Member

jonathanKingston commented Jul 17, 2017

@smichel17

This comment has been minimized.

Show comment
Hide comment
@smichel17

smichel17 Jul 17, 2017

The message only shows the first time you click the icon. I've missed messages before because I accidentally double clicked and closed the message before I could read it, or because the drop down happened not to render prpoerly that time. Suggestion: show the message each time until the user clicks 'ok'.

smichel17 commented Jul 17, 2017

The message only shows the first time you click the icon. I've missed messages before because I accidentally double clicked and closed the message before I could read it, or because the drop down happened not to render prpoerly that time. Suggestion: show the message each time until the user clicks 'ok'.

@jonathanKingston

This comment has been minimized.

Show comment
Hide comment
@jonathanKingston

jonathanKingston Jul 17, 2017

Member
Member

jonathanKingston commented Jul 17, 2017

@deimidis

This comment has been minimized.

Show comment
Hide comment
@deimidis

deimidis Jul 25, 2017

@jonathanKingston sorry, I just read your comment. In my case, I think it was my fault, just thought that you were implementing a new onboard process, but not read it.

Is there a way to add this as an option? (and by adding this I mean the option to chose the old behavior)

deimidis commented Jul 25, 2017

@jonathanKingston sorry, I just read your comment. In my case, I think it was my fault, just thought that you were implementing a new onboard process, but not read it.

Is there a way to add this as an option? (and by adding this I mean the option to chose the old behavior)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment