Adding assignment feature tests

[stoically]

Hi,

since jkt signaled on IRC that adding some tests to the codebase is OK, here's a proposal that loads popup.html and background/index.html with jsdom and executes a basic assignment feature test:

• Initialize browser with example.com tab in firefox-container-1
• Click the container-page-assigned checkbox to assign example.com to firefox-container-1
• Open new example.com tab in firefox-default container
• Should create new tab with confirm page url
• Should remove the new example.com tab in firefox-default container
• Click the checkbox again to remove assignment of example.com
• Open new example.com tab in firefox-default container
• Should not create a new tab

If you find this useful I could add more feature tests based on this. Of course I'm open to feedback and willing to change stuff - just let me know what you think.

Libs used: jsdom, mocha, sinon, chai

Bumped travis nodejs version to lts/* (latest LTS Node.js release) to have ES6 support in the tests

Best regards

[groovecoder]

Whoa, this is a cool PR. @jonathanKingston - do you have time to check this out this week?

[stoically]

Glad you like it. Refactored a bit and wired popup.browser.runtime.sendMessage with background.browser.runtime.onMessage. That way the click in the popup automatically triggers the background which makes it imho a more reliable feature test.

[stoically]

Finished the refactorings that I initially mentioned

• Rephrase and refactor the feature test to be less technical and more black-box-ish
• Don't check for browser.runtime.sendMessage and browser.storage.local.set but instead yield onBeforeRequest and check if MAC reopens the tab correctly
• Move "popup clicking" and "opening of tabs" behind helper functions - would make writing future feature tests easier

[stoically]

Tests currently fail because I've added one for #1114 - so if that should get merged, the tests would go green again. I can of course remove the test from this PR again, since it isn't really in the scope and in reality belongs to #1114. Just thought it's easier to see the test fail this way.

[jonathanKingston]

LGTM we should test in a release with the other patch mentioned though.