-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #1464
Refactor tests #1464
Conversation
16959bb
to
e3194ce
Compare
@stoically I'm not able to run this patch with all passing tests. Is there something wrong on my end or is that a known issue with this patch? |
@maxxcrawford You're right, it seems something introduced a regression since I've opened the PR (travis was green back then). Reopening to trigger a red build and looking into it when I get the chance. |
Interesting. So travis is green again, but locally |
e3194ce
to
9d22907
Compare
@maxxcrawford rebased and updated to latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these test rewrites. I'm trying to get a better sense of this testing suite (and the project as a whole). Could you break this PR into multiple commits for better readability? Specifically, separating the coverage, dependencies updates and each test (where applicable). Still one PR, but enough different commits to step through the refactor easier.
The good news is that Mozilla has bandwidth (and an intern!) to put towards this project over the next three months.
0247ee9
to
1932181
Compare
Separated the changes into multiple commits as requested, hope this helps with readability. As an aside: Facebook Container uses the dependency Looking forward to see progress in MAC! |
71a1e35
to
b10332e
Compare
99b9d3c
to
8b695f8
Compare
8b695f8
to
5b9f6e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this refactor!
Here's a test change only - updated with the latest dependencies - which was previously in #1190, but since it doesn't touch production code, I think it's good to merge into master.