-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove identityState when deleting containers #1141
Conversation
dfbdd8e
to
6e82a74
Compare
9220d56
to
96e221e
Compare
Some users of Temporary Containers are up to 100k+ opened (and deleted) containers, and hence with 100k entries in MACs storage.js. Would be nice if we could merge this to avoid it in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like #1131 is merged, but this is still red on Travis? I also tried to rebase this branch on latest master and got the same test failures. So I think this needs some updating before we can merge it.
96e221e
to
429338a
Compare
429338a
to
fe42e7e
Compare
fe42e7e
to
7d8fc80
Compare
I am one of the Temporary Containers users. Could this be related to #1675 ? |
@liambluebox It's not. It generates other left-over data. |
@groovecoder any chance this could be looked at? |
77f7a78
to
08e9ad7
Compare
08e9ad7
to
76d5b36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. LGTM.
Changes have been made and reviewed by me
Fixes #1140