Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on final name for this code #1

Closed
agrover opened this issue Mar 18, 2019 · 11 comments
Closed

Decide on final name for this code #1

agrover opened this issue Mar 18, 2019 · 11 comments

Comments

@agrover
Copy link
Contributor

agrover commented Mar 18, 2019

Yes it's a bikeshed, but it seems like some things are gated on resolving this. Here's some possibilities I'll throw out there:

  1. Neqo (current working name)
  2. Quico
  3. Minqo
  4. Sable (a Mink-like creature)
  5. Polecat (same as above)
  6. Quickness (QUIC + NSS)
  7. Morq (Mozilla-Originated Rust-based Quic)
  8. Marq (Mozilla-Authored Rust-based Quic)
  9. Jiffy
@valenting
Copy link
Collaborator

  1. Moqur (Mozilla Quick in Rust)
  2. QuicLiR (Quic Library in Rust)

@bholley
Copy link
Collaborator

bholley commented Mar 18, 2019

Morq is a nice nod to Mozilla lore [1].

[1] https://en.wikipedia.org/wiki/Mork_(file_format)

@martinthomson
Copy link
Member

image

@ddragana
Copy link
Contributor

image

this is nice, I like it

@agrover
Copy link
Contributor Author

agrover commented Mar 19, 2019

what is it and how would one pronounce it?

@ekr
Copy link
Contributor

ekr commented Mar 19, 2019

Kwikr

@selenamarie
Copy link

@ekr if the new name is kwikr (and today is the 13th anniversary of twttr btw) then let it be so along with this logo.

@ekr
Copy link
Contributor

ekr commented Apr 2, 2019

qubit

@martinthomson
Copy link
Member

neqo

@agrover
Copy link
Contributor Author

agrover commented May 7, 2019

Things are looking like the name will stay Neqo.

Will close this issue in 2 days if nothing changes.

@agrover
Copy link
Contributor Author

agrover commented May 10, 2019

So shall this code henceforth be known as "Neqo" until the end of days, and the official logo shall be [here].(#1 (comment))

@agrover agrover closed this as completed May 10, 2019
github-merge-queue bot pushed a commit that referenced this issue Jun 27, 2024
They seem to have a race condition that makes them crash.

I wasn't able to figure out why they crash, this seems to happen
inside NSS:
```
Process 47677 stopped
* thread #2, name = 'init_twice_withdb', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x000000019b4994f8 libsystem_pthread.dylib`pthread_mutex_lock + 12
libsystem_pthread.dylib`pthread_mutex_lock:
->  0x19b4994f8 <+12>: ldr    x8, [x0]
    0x19b4994fc <+16>: mov    w9, #0x545a ; =21594
    0x19b499500 <+20>: movk   w9, #0x4d55, lsl #16
    0x19b499504 <+24>: cmp    x8, x9
(lldb) up
frame #1: 0x0000000100802f58 libnspr4.dylib`PR_Lock + 20
libnspr4.dylib`PR_Lock:
->  0x100802f58 <+20>: bl     0x10080c0c0    ; symbol stub for: pthread_self
    0x100802f5c <+24>: str    x0, [x19, #0xb8]
    0x100802f60 <+28>: mov    w8, #0x1 ; =1
    0x100802f64 <+32>: str    w8, [x19, #0xb0]
(lldb) up
frame #2: 0x00000001007fc188 libnspr4.dylib`PR_CallOnce + 56
libnspr4.dylib`PR_CallOnce:
->  0x1007fc188 <+56>: ldr    w23, [x19]
    0x1007fc18c <+60>: ldr    w20, [x19, #0x8]
    0x1007fc190 <+64>: ldr    x0, [x22, #0x430]
    0x1007fc194 <+68>: bl     0x100802f74    ; PR_Unlock
(lldb) up
frame #3: 0x000000010066f634 libnss3.dylib`nss_Init + 112
libnss3.dylib`nss_Init:
->  0x10066f634 <+112>: cbz    w0, 0x10066f640 ; <+124>
    0x10066f638 <+116>: mov    w19, #-0x1 ; =-1
    0x10066f63c <+120>: b      0x10066f968    ; <+932>
    0x10066f640 <+124>: stp    x21, x22, [x29, #-0x80]
(lldb) up
frame #4: 0x000000010066ff44 libnss3.dylib`NSS_Initialize + 100
libnss3.dylib`NSS_Initialize:
->  0x10066ff44 <+100>: ldp    x29, x30, [sp, #0x40]
    0x10066ff48 <+104>: add    sp, sp, #0x50
    0x10066ff4c <+108>: ret

libnss3.dylib`NSS_InitContext:
    0x10066ff50 <+0>:   sub    sp, sp, #0x60
(lldb) up
frame #5: 0x00000001000035fc init-d4e9f02b33e50e46`init::init_twice_withdb::h34013f715e9b4f6e at init.rs:65:9
   62  	    let pathstr = path.to_str().unwrap();
   63  	    let dircstr = CString::new(pathstr).unwrap();
   64  	    unsafe {
-> 65  	        nss::NSS_Initialize(
   66  	            dircstr.as_ptr(),
   67  	            empty.as_ptr(),
   68  	            empty.as_ptr(),
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants