Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update .gitignore #1746

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

larseggert
Copy link
Collaborator

Add some things, remove some things...

Copy link

Benchmark results

Performance differences relative to 2750423.

  • coalesce_acked_from_zero 1+1 entries
    time: [255.55 ns 256.08 ns 256.68 ns]
    change: [-0.1433% +0.2288% +0.6116%] (p = 0.24 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [296.69 ns 297.40 ns 298.16 ns]
    change: [+1.8953% +2.2005% +2.4983%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [294.50 ns 295.27 ns 296.27 ns]
    change: [+0.6156% +1.4474% +2.3930%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [271.04 ns 282.52 ns 308.13 ns]
    change: [+0.8101% +3.0081% +6.8019%] (p = 0.05 < 0.05)
    Change within noise threshold.

  • RxStreamOrderer::inbound_frame()
    time: [125.92 ms 126.08 ms 126.32 ms]
    change: [-1.1298% -0.8968% -0.6554%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • Run multiple transfers with varying seeds
    time: [187.36 ms 188.00 ms 188.64 ms]
    change: [-2.6073% -2.1598% -1.7050%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • Run multiple transfers with the same seed
    time: [189.23 ms 189.60 ms 189.97 ms]
    change: [-1.8115% -1.5375% -1.2780%] (p = 0.00 < 0.05)
    💚 Performance has improved.

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Mar 15, 2024
Merged via the queue into mozilla:main with commit f2733e4 Mar 15, 2024
13 checks passed
@larseggert larseggert deleted the chore-gitignore branch March 15, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants