ci: Try to pin more deps #2163
Merged
ci: Try to pin more deps #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get our OSSF score up a bit.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36373 36373
=======================================
Hits 34697 34697
Misses 1676 1676 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 5677bd1. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.060 ns 99.400 ns 99.738 ns]
change: [+0.0382% +0.5257% +1.0289%] (p = 0.04 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.71 ns 116.97 ns 117.25 ns]
change: [+0.0113% +0.3031% +0.6252%] (p = 0.05 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.56 ns 117.04 ns 117.60 ns]
change: [-0.0523% +0.4584% +0.9411%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [96.962 ns 97.107 ns 97.282 ns]
change: [-1.9440% -1.0292% -0.1467%] (p = 0.02 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.96 ms 111.02 ms 111.09 ms]
change: [-0.2277% -0.1436% -0.0635%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.282 ms 26.338 ms 27.389 ms]
change: [-7.0294% -1.9370% +3.0051%] (p = 0.46 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.532 ms 36.145 ms 37.749 ms]
change: [-3.7595% +3.0150% +9.7749%] (p = 0.38 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [26.041 ms 26.792 ms 27.584 ms]
change: [-2.1288% +1.9994% +6.2736%] (p = 0.36 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.977 ms 41.967 ms 44.012 ms]
change: [-5.9722% +0.5109% +7.1659%] (p = 0.89 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.33 ms 113.72 ms 114.10 ms]
thrpt: [876.46 MiB/s 879.32 MiB/s 882.36 MiB/s]
change:
time: [-0.5214% -0.0695% +0.3496%] (p = 0.76 > 0.05)
thrpt: [-0.3484% +0.0695% +0.5241%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [310.00 ms 313.44 ms 316.81 ms]
thrpt: [31.564 Kelem/s 31.904 Kelem/s 32.258 Kelem/s]
change:
time: [-2.7644% -1.1894% +0.4031%] (p = 0.15 > 0.05)
thrpt: [-0.4014% +1.2038% +2.8430%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.819 ms 34.012 ms 34.217 ms]
thrpt: [29.225 elem/s 29.402 elem/s 29.569 elem/s]
change:
time: [-1.1174% -0.4196% +0.3099%] (p = 0.25 > 0.05)
thrpt: [-0.3089% +0.4214% +1.1300%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get our OSSF score up a bit.