test: Dump simulator RNG seeds #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Into the directory given in the `DUMP_SIMULATION_SEEDS` environment variable. Also, export them as artifacts from the CI runs. Fixes mozilla#1645
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
- Coverage 95.39% 95.38% -0.01%
==========================================
Files 112 112
Lines 36373 36373
==========================================
- Hits 34697 34696 -1
- Misses 1676 1677 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Benchmark resultsPerformance differences relative to 249d062. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.671 ns 98.990 ns 99.315 ns]
change: [-0.6423% -0.2622% +0.1362%] (p = 0.21 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.38 ns 116.69 ns 117.03 ns]
change: [-0.7423% -0.4520% -0.1792%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [116.03 ns 116.40 ns 116.86 ns]
change: [-2.0044% -1.0070% -0.2628%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.248 ns 97.404 ns 97.572 ns]
change: [-1.2663% -0.1279% +1.0260%] (p = 0.85 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.98 ms 111.04 ms 111.11 ms]
change: [-0.2564% -0.1746% -0.0937%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.389 ms 26.463 ms 27.539 ms]
change: [-7.0017% -2.0775% +3.1047%] (p = 0.44 > 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [32.221 ms 33.779 ms 35.365 ms]
change: [-13.935% -8.1528% -1.6404%] (p = 0.02 < 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.242 ms 26.045 ms 26.875 ms]
change: [-4.8638% -0.6457% +3.5050%] (p = 0.77 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [40.542 ms 42.521 ms 44.554 ms]
change: [-6.0567% -0.2418% +6.7835%] (p = 0.94 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [113.78 ms 114.17 ms 114.54 ms]
thrpt: [873.02 MiB/s 875.87 MiB/s 878.91 MiB/s]
change:
time: [-1.1122% -0.6722% -0.1764%] (p = 0.00 < 0.05)
thrpt: [+0.1767% +0.6767% +1.1247%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [312.52 ms 316.38 ms 320.22 ms]
thrpt: [31.228 Kelem/s 31.608 Kelem/s 31.998 Kelem/s]
change:
time: [-0.5527% +1.0820% +2.8382%] (p = 0.21 > 0.05)
thrpt: [-2.7598% -1.0704% +0.5557%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [34.026 ms 34.231 ms 34.455 ms]
thrpt: [29.023 elem/s 29.213 elem/s 29.389 elem/s]
change:
time: [-0.0599% +0.7421% +1.6343%] (p = 0.08 > 0.05)
thrpt: [-1.6080% -0.7366% +0.0600%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
Signed-off-by: Lars Eggert <lars@eggert.org>
martinthomson
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Into the directory given in the
DUMP_SIMULATION_SEEDSenvironment variable. Also, export them as artifacts from the CI runs.Fixes #1645