Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Opus related changes #14

Merged
merged 3 commits into from
Nov 18, 2013
Merged

Some Opus related changes #14

merged 3 commits into from
Nov 18, 2013

Conversation

bit
Copy link
Contributor

@bit bit commented Nov 12, 2013

No description provided.

@rillian
Copy link
Contributor

rillian commented Nov 12, 2013

Would be nice if the indentation fixes were a separate commit.

@@ -140,6 +140,8 @@
double rate; /**< Sampling rate in Hz. */
unsigned int channels; /**< Number of audio channels. */
unsigned int depth; /**< Bits per sample. */
uint64_t codec_delay;
uint64_t seek_preroll;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add Doxygen comments for these new fields?

@kinetiknz
Copy link
Collaborator

Thanks! I'll merge once the two new fields are documented.

@bit
Copy link
Contributor Author

bit commented Nov 13, 2013

@rillian indention is not fixed but that block is only done for vorbis.

 - add new api call nestegg_packet_discard_padding
   to get DiscardPadding for given packet
kinetiknz added a commit that referenced this pull request Nov 18, 2013
Additional support for Opus codec handling.
@kinetiknz kinetiknz merged commit 0617a70 into mozilla:master Nov 18, 2013
@kinetiknz
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants