Fix the definition of max_align_t for Windows #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-cl currently chokes on this code because of the incompatible typedefs.
|
I think I'd prefer max_align_t to be defined only if it's not already defined. |
Well, that's hard. max_align_t is supposed to be available in C++11 but it's not in the libstdc++ shipped with Ubuntu 14.04, for example. And unfortunately we cannot detect the existence of typedefs in C++, so I'm not sure how to do what you suggest. |
kinetiknz
added a commit
that referenced
this pull request
Dec 11, 2014
Fix the definition of max_align_t for Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-cl currently chokes on this code because of the incompatible
typedefs.