Fix ne_read_float on big-endian machines. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I forgot the @. r? @SingingTree please :) |
SingingTree
approved these changes
Aug 21, 2019
| @@ -834,7 +834,15 @@ ne_read_float(nestegg_io * io, double * val, uint64_t length) | |||
| { | |||
| union { | |||
| uint64_t u; | |||
| float f; | |||
| struct { | |||
| #if __FLOAT_WORD_ORDER__ == __ORDER_BIG_ENDIAN__ | |||
There was a problem hiding this comment.
It appears there's broad support for these macros. I've tested a toy program with clang/gcc/msvc and they work -- but I haven't worked with these much, so wanted to highlight them in case you have any further thoughts.
There was a problem hiding this comment.
Thanks. Yeah, it's possible this won't be defined on some particular platform/compiler but the most common/likely ones are covered. In the event that this fix breaks for a big-endian system with a compiler that doesn't define __FLOAT_WORD_ORDER__, it is covered by the included regression tests (e.g. detodos.webm will fail) so it can, at least, be found and fixed quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64.
Verified fix via qemu-user with a MIPS build.
make checkpasses.r? SingingTree please