-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search page tech #328
Comments
I implemented this on the Science site- basically I didn't search until the user had stopped typing for a fraction of a second as seen here. You could couple that with your existing behavior and the Is the fact that search only looks in title/description a problem? What other fields should it search/exclude? |
It should search everything, searching tags and people will be important. I'm ok with having an Enter button if needed. Having one would also help clarify to users that they can share the url. |
I've opened a PR to support searching tags and creators. Keep in mind that tags specifically can be searched using the |
challenge 1 landed in the form of a PR that lets you call For challenge 2, this is an instance of "why not both" - use |
UX wise
Current plan: We would like to have "search as you type". And it should search through all entry fields/meta (@xmatthewx @kristinashu correct me if I'm wrong)
Tech wise
Before we had pagination on Pulse API, I used to just get all entries by one
/entries
call and bind search input box'skeyUp()
event with client side filtering. The client side filter searches through all entry meta (not justtitle
ordescription
) and returns entries that have meta matched the search keyword.Since now pagination on Pulse API is enabled by default, I wonder what the best way is to implement the search functionality.
/entries
calls have to be made in order to fetch all entries in the database/entries?search=
param (note it currently searches through title and description only)? If so, does that mean we have to make a new API call on every keystroke? 😨Maybe we should set some limitation on how search works. e.g., don't enable search-as-you-type. instead let 'Enter' trigger the search?
/cc @Pomax @alanmoo @kristinashu @xmatthewx
The text was updated successfully, but these errors were encountered: