Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project-list component #361

Closed
alanmoo opened this issue Feb 10, 2017 · 1 comment
Closed

Refactor project-list component #361

alanmoo opened this issue Feb 10, 2017 · 1 comment

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Feb 10, 2017

The project-list component seems to be doing a bit too much, causing some issues with the different ways it's used requiring band-aids.

Let's simplify the API of it, here's my thought:

Project List gets passed in 2 props: projects, which is an array of objects (entries from the API), and sortBy, a key to sort the projects by or a list of IDs by which to order them.

Any other logic in there gets pulled up a level (like the issues bit) so that those higher components handle fetching the data and passing it in to the Project List. This should also allow you to DRY out the search.jsx and project-list.jsx files.

In addition, the CSS could be cleaned up a bit to use bootstrap classes and less custom styles.

@mmmavis
Copy link
Member

mmmavis commented Mar 15, 2017

Fixed in PR #410.

@mmmavis mmmavis closed this as completed Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants