Add basic Seamonkey support to titlebar customization #31

Closed
xabolcs opened this Issue Mar 11, 2012 · 13 comments

Projects

None yet

3 participants

Collaborator
xabolcs commented Mar 11, 2012

@tonymec and I talked a little bit on mozillaZine about how to support Seamonkey.
It isn't trivial. SM has got two window types, at least. :)

Depends on #20 - wait for it's "output", and reuse from modules as much as possible.

This issue was modified to contain BASIC titlebar customization only!
It overlays chrome://navigator/content/navigator.xul only!

Contributor
whimboo commented Mar 12, 2012

Sounds fair enough. Code should be window type specific and we should take care of in #20 as well.

Collaborator
xabolcs commented Oct 22, 2012

@tonymec noted again that NTT doesn't support SeaMonkey:

Recent updates on the NTT github master mention a "Customize Titlebar" dialog. Where is that dialog?
...

Phillip Chee's commit does the most of work with SeaMonkey's main window.

@tonymec (as SM and NTT user) (and also @whimboo) do You agree with
porting Philip's commit now (read: support browser window-types only)
and adding mail window-type support later (and the shared module enchancement)?

Contributor
tonymec commented Oct 23, 2012

On 22/10/12 22:37, Szabolcs Hubai wrote:

@tonymec https://github.com/tonymec noted again that NTT doesn't
support SeaMonkey:

Recent updates on the NTT github master mention a "Customize
Titlebar" dialog. Where is that dialog?
...

Phillip Chee's commit
http://hg.oxymoronical.com/extensions/NightlyTesterTools/rev/2c468e058583
does the most of work with SeaMonkey's main window.

@tonymec https://github.com/tonymec (as SM and NTT user) (and also
@whimboo https://github.com/whimboo) do You agree with
porting Philip's commit now (read: support browser window-types only)
and adding mail window-type support later (and the shared module
enchancement)?

IMHO, titlebar customization only in the browser is better than none.
IIRC, when NTT was “temporarily” unsupported and MR-Tech Toolkit was
working on all Toolkit applications (i.e., until Firefox 4, Gecko 2,
etc., not included), the MRTT title customization was only “good for the
browser” (e.g., even in the Mail window, the numbers of windows and tabs
that it could display were browser windows and browser tabs).

So my take on this question is: if you can do browser window title
customization (relatively) easily, by all means go ahead and do it, and
if mail window title customization will have to lag behind, well, so be it.

Best regards,

Tony.

MESKIMEN'S LAW
There's never time to do it right, but always time to do it over.

@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Oct 26, 2012
@xabolcs xabolcs Issue #31 - add Customize Titlebar menuitem c061e36
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Oct 26, 2012
@xabolcs xabolcs Issue #31 - implement browser window title customization 286bb22
Collaborator
xabolcs commented Oct 26, 2012

@whimboo, @tonymec
Are there a little chance to include this in milestone 3.4?

@xabolcs xabolcs was assigned Oct 26, 2012
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Oct 27, 2012
@xabolcs xabolcs Issue #31 - moar advanced workaround 5e0db21
Contributor
whimboo commented Nov 6, 2012

If we get the remaining issue fixed which @tonymec is facing, I would be happy to include it.

Collaborator
xabolcs commented Nov 6, 2012

@tonymec's issue is not just his issue as You can read in the related pull request (#104).
It's introduced with commit 3bb023c1c4da, shipped as NTT 3.0.

Collaborator
xabolcs commented Nov 6, 2012

Opps, wrong number. 103 should be #104 👅

Contributor
whimboo commented Nov 6, 2012

If that's the case we can go ahead with pull #104 once I got the confirmation from tony.

Collaborator
xabolcs commented Nov 6, 2012

That would be fine! :)

Contributor
tonymec commented Nov 6, 2012

@whimboo Which confirmation? Do you want me to test some advance build? Normally I pull the "mozilla" master on my local clone (I refrained recently because it had no titlebat customization and I had a "test xpi" which fixed that, well, except for that "known issue"), but I can test any xpi if I know exactly which one.

Collaborator
xabolcs commented Nov 6, 2012

@tonymec: check #104! (specifically comment-10105675)

@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Nov 9, 2012
@xabolcs xabolcs Issue #31 - var tabbrowser = .... -> gBrowser d51983f
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Nov 9, 2012
@xabolcs xabolcs Issue #31 - more nightly.oldUpdateTitlebar checks cc899b5
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Nov 9, 2012
@xabolcs xabolcs Issue #31 - little documentation, extra space nit 22afc5a
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Nov 9, 2012
@xabolcs xabolcs Issue #31 - nightly.oldUpdateTitlebar -> getter / setter, even more c…
…hecks
6b147ac
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Nov 16, 2012
@xabolcs xabolcs Issue #31 - addressing comments part 2:
- aBroswer -> call(gBrowser) + this
- getWindowTitleForNavigator jsdoc description
- docShell.contentViewer jsdoc TODO
- not polluting with Logger.jsm
d124915
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue Apr 28, 2013
@xabolcs xabolcs Issue #31 - addressing comments part 3 4a569aa
@xabolcs xabolcs added a commit to xabolcs/nightlytt that referenced this issue May 5, 2013
@xabolcs xabolcs Issue #31 - addressing comments part 4 572f6b0
Contributor
whimboo commented May 7, 2013

@xabolcs thank you for the patch! Good to see that this feature has been landed now.

@whimboo whimboo closed this May 7, 2013
Collaborator
xabolcs commented May 24, 2013

Edited description:

  • this is a basic extension to NTT
  • NTT overlays only the navigator window in Seamonkey, and this issue doesn't change that
  • see the talk on mozillaZine about the full support of Seamonkey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment