Open customize.xul as a resizable window. Fixes #55. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set it's dimensions to 3:2.
|
Why does it need pull #74 merged first? I don't see why. Otherwise it looks good, but not tested yet. |
|
Looks good. Pushed: |
|
I thought that I would be the author. :'( |
whimboo
added a commit
that referenced
this pull request
Jun 12, 2012
Open customize.xul as a resizable window (79)
|
Sorry, something went wrong with the merge. Should be fixed now. |
|
Is github broken? I'm still the author of this patch!? |
|
whimboo commented
The reverted 05ae130 is still yours, but my commit is in the tree now too. :) |
|
Wait. The merge commit is from myself but the actual code landing is yours. Solved! :) Sorry again. |
| @@ -41,9 +41,10 @@ | |||
|
|
|||
| <prefwindow id="NightlyTesterOptions" windowtype="NightlyTester:Customize" | |||
| title="&nightly.customize.title;" | |||
| style="width: 42.75em; height: 28.5em" persist="width height" | |||
There was a problem hiding this comment.
#74 (re)introduces titlebar.css. If that pull lands, move this styling there!
There was a problem hiding this comment.
Has this already been moved over?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also set it's dimensions to 3:2.
As I know, it applies almost cleanly to top of #74.