firefox-nightly: use patched patchelf (heh) to not break binaries #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcunat
reviewed
Sep 24, 2023
| patches = old.patches or [] ++ [ ./no-clobber-old-sections.patch ]; | ||
| }); | ||
| in stdenv.mkDerivation { | ||
| pname = "patchelf-wrapped"; |
nbp
approved these changes
Sep 25, 2023
Comment on lines
+3
to
+4
| patchelf' = patchelf.overrideAttrs(old: { | ||
| patches = old.patches or [] ++ [ ./no-clobber-old-sections.patch ]; |
There was a problem hiding this comment.
This sounds good for now, but it would be good to make it work for both patched (making this code a no-op) and non-patched versions of patchelf.
In the mean time I am going to accept it as most users are more likely to not be able to update nightly anymore.
Thanks for figuring out the issue and providing the patches!
There was a problem hiding this comment.
We can hopefully just rip this out when the fixed patchelf makes it to nixpkgs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.