Pull text-encoding from npm instead of from vtt.js bower dist. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text-encoding lib (formerly stringencoding) was previously not on npm and so I elected to pull it from vtt.js bower distributable instead of using a git submodule, since the current version of it was broken. It's on npm now so we can pull directly from there and get rid of our bower dependencies.
|
r=me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text-encoding lib (formerly stringencoding) was previously not
on npm and so I elected to pull it from vtt.js bower distributable
instead of using a git submodule, since the current version of it
was broken. It's on npm now so we can pull directly from there and
get rid of our bower dependencies.