Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io should be a regular dependency. #32

Merged
merged 1 commit into from
Jun 18, 2014

Conversation

RickEyre
Copy link
Contributor

If someone is npm installing node-vtt the incorrect version
of socket.io is going to be installed since it will not install
dev dependencies by default.

Could you review please @alicoding?

If someone is npm installing node-vtt the incorrect version
of socket.io is going to be installed since it will not install
dev dependencies by default.
@alicoding
Copy link

r=me

@RickEyre RickEyre merged commit 6f47e61 into mozilla:master Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants