Test that the docs build #1453
Merged
Test that the docs build #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
And the caching worked for the docs part.
|
|
Weird that I didn't get this locally! UPDATE Nevermind. I did get this error locally. |
mythmon
suggested changes
Aug 16, 2018
peterbe
commented
Aug 16, 2018
| mv ~/docker-compose /usr/local/bin/docker-compose | ||
| curl -L https://github.com/docker/compose/releases/download/1.19.0/docker-compose-`uname -s`-`uname -m` > ~/docker-compose | ||
| chmod +x ~/docker-compose | ||
| mv ~/docker-compose /usr/local/bin/docker-compose |
There was a problem hiding this comment.
By the way, some Yaml plugin in vscode did this. I'm a bit surprised it was enabled to "formatOnSave" by default. Either way, can't hurt.
mythmon
approved these changes
Aug 16, 2018
|
Looks good. I'll let you handle bors yourself, since it looks like wanted to squash all this. bors delegate= @peterbe |
|
✌️ peterbe can now approve this pull request |
peterbe
force-pushed
the
1441-test-that-the-docs-build
branch
from
e004f02
to
080898f
Compare
|
uh? What do I do? Just |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 16, 2018
1453: Test that the docs build r=peterbe a=peterbe Fixes #1441 These steps work locally but I'm going to see if messing with one of the `.rst` files actually breaks the build. - [x] Test that it works - [x] Test that `.rst` failures "break the build" - [x] Squash commits to clean up Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441
These steps work locally but I'm going to see if messing with one of the
.rstfiles actually breaks the build..rstfailures "break the build"