Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Should I get signed out of Notes when I sign out of Sync? #11

Closed
rfk opened this issue Jun 8, 2017 · 10 comments
Closed

Should I get signed out of Notes when I sign out of Sync? #11

rfk opened this issue Jun 8, 2017 · 10 comments
Milestone

Comments

@rfk
Copy link

rfk commented Jun 8, 2017

(sorry if there's a mailing list I should ask this on instead, I couldn't find one in my notes)

I'm trying to make sure I have my head around the relationship between being logged in to Firefox Sync, and being logged in to the Notes webextension. IIUC the intention is for these to be two separate and independent login states despite co-existing in the same browser, right?

If I'm signed in to sync, and I go to sign in to the Notes webextension, then I get a nice experience where it already knows who I am and I just have to re-enter my password to enable Notes to start syncing. I think that feels pretty solid.

But what happens if I then sign out of sync in my browser? Will the Notes webextension stay signed in and keep syncing? Is the user going to find that surprising? They may not have a good mental model of the two things being distinct.

@vladikoff
Copy link
Contributor

No mailing list :)

@vladikoff vladikoff modified the milestone: Launch Jun 13, 2017
@ryanfeeley
Copy link
Contributor

@rfk @vladikoff As this is a Test Pilot experiment, and the user is signing in to "Firefox Notes", I'd say they are not coupled in any way. Signing out of one will not affect the other.

However if a user deletes their account, we should delete it (eventually if not immediately).

@Natim
Copy link
Collaborator

Natim commented Jun 16, 2017

if a user deletes their account, we should delete it (eventually if not immediately).

Do we have a way to know that from Kinto? Like a webhook we can register somewhere or something?

@ryanfeeley
Copy link
Contributor

Maybe? @vladikoff?

@rfk
Copy link
Author

rfk commented Jun 19, 2017

However if a user deletes their account, we should delete it (eventually if not immediately).

For other services such as Sync, we've set up a backchannel SQS queue from which you can get account lifecycle events such as deletions. Will that be workable here?

(A webhook would be neat going forward, but more engineering work in the short term)

@Natim
Copy link
Collaborator

Natim commented Jun 19, 2017

The plan is to stick with web-extensions compatibility. I don't think WebExtension would have access to that SQS queue.

Is it possible to guess this by not being able to access the Kinto server with the current token and as a consequence disconnect the user?

@vladikoff
Copy link
Contributor

@ryanfeeley says " Don't worry about singing out users when Firefox Sync signs out"

@ryanfeeley
Copy link
Contributor

🎤👨‍🎤

@rfk
Copy link
Author

rfk commented Jun 19, 2017

However if a user deletes their account, we should delete it (eventually if not immediately).

Do we need a separate issue for this account-deletion part?

@ryanfeeley
Copy link
Contributor

@rfk I wouldn't make that a high priority for a test pilot release. Hell, I don't think our mobile clients even handle it properly with sync yet. But if we develop this further I would definitely revert the user to unauthenticated state and fire a desktop notification like this one we use for sync (but with Notes wording)
screenshot 2017-06-19 14 05 07

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants