Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

font sizes don't match #28

Closed
vladikoff opened this issue Jun 13, 2017 · 4 comments
Closed

font sizes don't match #28

vladikoff opened this issue Jun 13, 2017 · 4 comments
Assignees
Milestone

Comments

@vladikoff
Copy link
Contributor

image

See slab/quill#1208 (comment)

(
Also see slab/quill#491
And maybe slab/quill#1493
)

@vladikoff
Copy link
Contributor Author

@ryanfeeley do you want to make the text size 18 or do you want to change the value in the dropdown from 18 to a greater value?

@vladikoff
Copy link
Contributor Author

from notes: drop down fonts don't need to be sized to match font, numbers will suffice

@vladikoff vladikoff modified the milestone: Launch Jun 13, 2017
@ryanfeeley
Copy link
Contributor

@vladikoff My hunch is that this font size is more about finding a comfortable size for all of the text and not formatting notes with heading, subheadings (and subsubheadings, etc). That (likely) being the case, I think we should focus on sizes for readability and not formatting. Our reader mode uses these 9 sizes. I think we could probably be fine with the first 5 sizes. Make sense?

#container.font-size1 {
  font-size: 12px;
}

#container.font-size2 {
  font-size: 14px;
}

#container.font-size3 {
  font-size: 16px;
}

#container.font-size4  {
  font-size: 18px;
}

#container.font-size5 {
  font-size: 20px;
}

#container.font-size6 {
  font-size: 22px;
}

#container.font-size7 {
  font-size: 24px;
}

#container.font-size8 {
  font-size: 26px;
}

#container.font-size9 {
  font-size: 28px;
}

@Natim
Copy link
Collaborator

Natim commented Jun 16, 2017

Is that fixed already? It seems to me that the current behavior is much better:

current-behavior

@Natim Natim self-assigned this Jun 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants