The "Firefox Notes" toolbar button is not visible when the browser's dark theme is activated

[Softvision-MariusComan]

[Affected versions]:

• Firefox 57.0.4 and up

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a Firefox profile with the latest version of the "Firefox Notes" add-on (2.2.0dev custom build from 01.16.2018) installed.
• Have the "Dark" theme enabled from about:addons->Themes.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Observe the "Firefox Notes" toolbar button.

[Expected result]:

• The button is visible.

[Actual result]:

• The button blends in with the background.

[Notes]:

• The issue is not reproducible with the TxP version of "Firefox Notes".
• Attached a screen recording of the issue:
  

[Natim]

When we merged it it was looking like that:

[Natim]

I can reproduce on Linux but we can't on Mac (we tried with release/beta and nightly versions) I am suspecting a Firefox bug.

[Natim]

We can reproduce on Windows.

[Natim]

It seems to work only on retina displays...

[sebastienbarbier]

Could solve this issue by adding in manifest "theme_icons" size 16 in the list. Will push a fix soon.

[Natim]

Refs https://bugzilla.mozilla.org/show_bug.cgi?id=1404568#c27

[Natim]

Released in https://github.com/mozilla/notes/files/1642619/notes-2.1.1rc2.zip

[Softvision-MariusComan]

The issue is no longer reproducible with the latest version of the "Firefox Notes" add-on (2.2.0dev custom build from 01.25.2018) installed, on the latest Firefox release and Nightly.