Synchronous for+include generate asynchronous code instead of synchronous

[tdelmas]

According to the documentation :

https://mozilla.github.io/nunjucks/templating.html#asynceach

asyncEach is an asynchronous version of for. You only need this if you are using a custom template loader that is asynchronous;

Before, the compilation of

{% for item in items %}
  {% include "item-template.html" %}
{% endfor %}

The compilation generate synchronous calls but after that commit :
7d4716f

the same code is considered as asynchronous.

According to the documentation, the writer of the template is supposed to decide between for and asyncEach but according to that commit, to compiler for the code to be asynchronous.

As the recursion limits of Firefox and safari can be as low as 500, it became really easy to hit these limits.

Am I missing something ?

[carljm]

@jlongster Do you have any comment on this? I'm not really familiar with the async stuff at all.

[carljm]

@tdelmas The commit you linked certainly seems wrong to me. Simply using an include should not automatically trigger async, unless you've explicitly asked for an async loop.

Unless @jlongster weighs in to defend that commit, I will plan to revert it.

[nicolasartman]

@carljm Anything blocking the revert? I just ran into this as it made it impossible to catch errors in includes, so I would love to see this fixed.

[carljm]

I think I was hoping to get more of an explanation from @jlongster before reverting, but since that doesn't seem to be forthcoming, I'll go ahead and revert it today.

[nicolasartman]

Thank you!