Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order of context/frame lookup (issue #119) #122

Merged
merged 1 commit into from
Aug 21, 2013

Conversation

mattbasta
Copy link
Contributor

I don't know if there's any particular reason why contextOrFrameLookup looks at context first, but I think this has been the cause of a lot of heartache surrounding the {% set %} block and also macro arguments. If something in the frame overrides something in the context, the context was still being trusted.

The tests pass for me, as well, which I found both pleasant and surprising.

@jlongster
Copy link
Contributor

I can't remember a specific reason... it may have been out of fear of accidentally clobbering a context value with an internal variable name. But that should never happen, so you're right, it sounds like this should be the right order. We'll just have to see if any issues are files about it in the next release.

jlongster added a commit that referenced this pull request Aug 21, 2013
Reverse order of context/frame lookup (issue #119)
@jlongster jlongster merged commit 254b0eb into mozilla:master Aug 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants