Reverse order of context/frame lookup (issue #119) #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if there's any particular reason why
contextOrFrameLookup
looks atcontext
first, but I think this has been the cause of a lot of heartache surrounding the{% set %}
block and also macro arguments. If something in the frame overrides something in the context, the context was still being trusted.The tests pass for me, as well, which I found both pleasant and surprising.