Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement import with context #319

Merged
merged 2 commits into from
Dec 11, 2014
Merged

implement import with context #319

merged 2 commits into from
Dec 11, 2014

Conversation

nikku
Copy link
Contributor

@nikku nikku commented Nov 11, 2014

Closes #90

@carljm
Copy link
Contributor

carljm commented Nov 11, 2014

What about also adding a test that the without context syntax behaves correctly?

Otherwise, this looks pretty good to me; tests pass, code looks reasonable.

@nikku
Copy link
Contributor Author

nikku commented Nov 12, 2014

Here you are.

@carljm carljm merged commit d5fd4c4 into mozilla:master Dec 11, 2014
@carljm
Copy link
Contributor

carljm commented Dec 11, 2014

Merged. Thanks for the PR! Sorry it took me a while to get back to it.

@ArmorDarks ArmorDarks mentioned this pull request Apr 16, 2015
Closed
@nikku nikku deleted the with-context branch March 20, 2016 20:43
@matthewmascord matthewmascord mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jinja2 with context
2 participants
@nikku @carljm