Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trimBlocks also trim windows style line endings #548

Merged
merged 2 commits into from
Oct 7, 2015

Conversation

magnusjt
Copy link
Contributor

@magnusjt magnusjt commented Oct 7, 2015

When trimBlocks is enabled, only unix-style (LF) line endings are removed from the end of blocks. This pull request makes it so that also windows style (CRLF) line endings are removed.

@carljm
Copy link
Contributor

carljm commented Oct 7, 2015

Looks good to me! Thanks for the contribution. Would you mind adding a note to the Changelog file? Then I'll merge.

@magnusjt
Copy link
Contributor Author

magnusjt commented Oct 7, 2015

Added a note as requested :)

carljm added a commit that referenced this pull request Oct 7, 2015
Make trimBlocks also trim windows style line endings
@carljm carljm merged commit 90e3913 into mozilla:master Oct 7, 2015
@carljm
Copy link
Contributor

carljm commented Oct 7, 2015

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants