Add optional "preserve linebreaks" behavior for striptags filter
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's often desired to pipe {{ text | striptags | nl2br }}.
For example, when we're rendering email template from feedback form.
This commit adds an option to remove tags, keeping significant whitespace.
Merged
| return r.copySafeness(input, filters.trim(input.replace(tags, '')).replace(/\s+/gi, ' ')); | ||
| var res = ''; | ||
| if (preserve_linebreaks) { | ||
| res = filters.trim(input.replace(tags, '')) |
There was a problem hiding this comment.
Why not extract the common filters.trim(input.replace(tags, '')) outside of the if/else?
|
Looks good, thanks! Any chance you'd be willing to add docs for this new option to the PR? |
|
Right, I forgot about docs 😞 Will add them today. |
|
Added 😉 |
|
Thanks for the excellent PR, and for taking care of all the little details :-) Merging. |
carljm
added a commit
that referenced
this pull request
Dec 23, 2015
Add optional "preserve linebreaks" behavior for `striptags` filter
|
Just released this feature in v2.3.0. Thanks again! |
|
@carljm nevermind, you are welcome! |
vecmezoni
pushed a commit
that referenced
this pull request
Oct 24, 2016
* Rebase * Add more real usecase for nl2br cf. #619 * no-extra-parens + remove \r support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often desired to pipe
{{ text | striptags | nl2br }}.For example, when we're rendering email template from feedback form.
This commit adds an option to remove tags, keeping significant whitespace.
{{ text | striptags(true) | nl2br }}This converts a messy
to a human-readable form