Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Add resources to README #41

Merged
merged 7 commits into from
Mar 13, 2019
Merged

Add resources to README #41

merged 7 commits into from
Mar 13, 2019

Conversation

asquare14
Copy link
Contributor

@asquare14 asquare14 commented Mar 13, 2019

Mentioned about these resources on gitter.

@birdsarah
Copy link
Contributor

This PR doesn't make sense in context with your earlier one, now merged. I like the idea of moving that piece to a resources section - maybe at the bottom near the glossary.

Other small tweaks - consider rewriting the "please update readme based on our learnings" to something that reads better for a newcomer.

Maybe lets rename that section "New contributor tips"

@asquare14
Copy link
Contributor Author

Sure. Will do that

@asquare14
Copy link
Contributor Author

@birdsarah Is this ok ?

@birdsarah
Copy link
Contributor

Instead of "is this ok?" you can just say "ready for review" or, better yet, when you're working on PR you can add "WIP" which stands for "work in progress" to the title. And when you're done remove the "WIP" ... I could also add labels to help with this process.

You'll find out the answer to the question "is this ok?" on review. But review is always an iterative process.

@birdsarah birdsarah merged commit 269ec12 into mozilla:master Mar 13, 2019
@asquare14
Copy link
Contributor Author

asquare14 commented Mar 14, 2019 via email

@asquare14 asquare14 deleted the resources branch March 15, 2019 04:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants