Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

Test using domino instead of jsdom #30

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

jaredlockhart
Copy link
Collaborator

No description provided.

@jaredlockhart jaredlockhart merged commit 82ac24e into mozilla:master Jul 14, 2016
@erikrose
Copy link

Looks sane to me. r+

@erikrose
Copy link

Actually, domino talks about not being suitable for untrusted input. So, hmmm.

@erikrose
Copy link

I see it doesn't download external resource or execute scripts, so I'm not sure what they're talking about.

@pdehaan
Copy link
Contributor

pdehaan commented Jul 14, 2016

A couple other refs to jsdom which may now need revisiting:

  1. /karma.conf.js:32:

      externals: {
        'jsdom': 'jsdom',
      },
  2. /README.md:19:

    Each function expects to be passed a Document object, which may be created either directly by a browser or on the server using a Document compatible object, such as that provided by jsdom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants