This repository has been archived by the owner on Feb 24, 2022. It is now read-only.
Scrape image:width and image:height, if available #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling f61329f on pdehaan:add-image-dimensions into * on mozilla:master*. |
pdehaan
force-pushed
the
add-image-dimensions
branch
from
f61329f
to
7c88bc8
Compare
|
Changes Unknown when pulling 7c88bc8 on pdehaan:add-image-dimensions into * on mozilla:master*. |
| @@ -34,6 +34,7 @@ const titleRules = buildRuleset('title', [ | |||
|
|
|||
| const canonicalUrlRules = buildRuleset('url', [ | |||
| ['meta[property="og:url"]', node => node.element.content], | |||
| ['meta[name="twitter:url"]', node => node.element.content], | |||
There was a problem hiding this comment.
This should be a separate PR.
|
After reading http://ogp.me/#array I'm not convinced my logic would work in all/most cases. |
|
Closing for now, until I'm ready to fix this properly (or we move to fastimage, per mozilla/page-metadata-service#89) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs a bit of tweaking on page-metadata-service