-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display widget signature in SVG #13219
Comments
No, that's not really necessary since the FAQ specifically mentions that the SVG-backend is unsupported (it will never perform well enough for general use, given the huge number of DOM-elements it creates); please note https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#backends
Sorry, but while you might want that, we have no such requirements at all (since that'd only serve to slow down/hinder overall development of the |
This is, for all intents and purposes, a duplicate of #10165 |
@Snuffleupagus this does stand in contrast to a recently closed project
|
No, it doesn't since the information which is provided in the FAQ is the official position. That project was closed since there's no work happening/planned for the SVG-backend, for the reasons already mentioned. (Generally speaking, the mere closing of an old and now irrelevant project cannot be construed as something automatically being supported.) |
I would love to know what it takes to keep the SVG backend at parity. In your assessment would one developer fully dedicated to it be enough or does it require more effort? (I understand you might prefer not to burden all developers to consider both backends as you prioritize the canvas one for Mozilla's use.) |
Please read what I've already written (multiple times now), which is that the sheer number of DOM elements generated for anything but trivial PDF documents will lead to really poor memory usage and very poor overall performance (e.g. when scrolling).
The demo viewer already limits the number of visible/rendered pages, regardless of backend, to improve performance and reduce memory usage. For the SVG-backend that's, as already mentioned, still not enough in many cases!
You'd have to somehow get browsers to handle the case of huge amounts of DOM elements better, there's generally speaking nothing we can do about that here.
No-one ought to be using the SVG-backend, given its issues. In my personal opinion: it'd basically be a waste of development/reviewer resources to work on the SVG-backend, all things considered. The reason why work on the SVG-backend stopped, is that it wasn't deemed feasible to get in working as well (overall) as the canvas-backend already does. |
@timvandermeij Mind closing this, please note #13219 (comment). |
Yes, this is indeed a duplicate. |
Attach (recommended) or Link to PDF file here:
https://github.com/mozilla/pdf.js/blob/master/test/pdfs/bug854315.pdf
Configuration:
Steps to reproduce the problem:
What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
SVG backend was not updated with #13214
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
http://54.67.70.0:8877/f90cd937a5806b8/web/viewer.html
https://mozilla.github.io/pdf.js/web/viewer.html
@calixteman
I think it is important to keep the two renderers in sync. Pull requests that break this should at least mention what needs to be done in the other backend to maintain feature parity.
The text was updated successfully, but these errors were encountered: