Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some UI feedback when a PDF fails to load for any reason #16599

Open
Rob--W opened this issue Jun 25, 2023 · 7 comments
Open

Add some UI feedback when a PDF fails to load for any reason #16599

Rob--W opened this issue Jun 25, 2023 · 7 comments
Labels

Comments

@Rob--W
Copy link
Member

Rob--W commented Jun 25, 2023

The generic errorWrapper was removed in #15533, motivated by code simplification and reducing the translated strings. The result is zero UI feedback when the PDF fails to load/render for any reason.

Examples:

I'd like to restore the UI feedback, at least in the Chrome extension. It doesn't have to be the same as the original, even dumping the raw error message (which are still translated by the way) would suffice.

@Rob--W
Copy link
Member Author

Rob--W commented Jun 25, 2023

@Snuffleupagus As the author of #15533, what do you think of this? Should this be in the generic viewer UI or be Chrome-specific?

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jun 25, 2023

As the author of #15533, what do you think of this?

That was done specifically to reduce the amount of code that needs to be maintained. Furthermore, the current behaviour is also consistent across builds since the Firefox PDF Viewer no longer displays any error messages (except the console logging).

There's some discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1795859 about possible surfacing error messages more visibly, hence I very much believe that we should await the conclusion of that bug before re-adding any build-specific code to the viewer for this purpose.

@Rob--W
Copy link
Member Author

Rob--W commented Jun 25, 2023

Thanks for linking that issue. I'll link this issue from Bugzilla, so that if there is any resolution, it will be mirrored to both issue trackers.

@Aditay2002

This comment was marked as outdated.

@Rob--W
Copy link
Member Author

Rob--W commented Jun 26, 2023

@Rob--W how can i explore more about the issue?

If you are wondering about how to trigger this scenario, see #16271 for manual reproduction steps.

Note that this issue is not yet actionable until a decision has been made (see #16599 (comment)).

@Aditay2002

This comment was marked as outdated.

@Aditay2002

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants