You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before #16543, TypeScript type for SVGGraphics was any. Now, it returns correct types. Congrats!
But, I believe there is a small mistake.
SVGGraphics.getSVG has type of (operatorList: PDFOperatorList, viewport: PageViewport) => Promise<void>, which I believe is not accurate representation of what this method does. I think it's supposed to be (operatorList: PDFOperatorList, viewport: PageViewport) => Promise<SVGElement>.
The text was updated successfully, but these errors were encountered:
First of all, please note that the SVG back-end is deprecated and thus should not be used. It may also be completely removed soon, see PR #16699, hence it's not clear to me that it makes much sense to try and fix this unfortunately.
Secondly, unless a TypeScript user steps up and helps out, the type-definitions are possibly going to be broken in the next PDF.js release; please see issue #16705 for additional details.
Before #16543, TypeScript type for
SVGGraphics
wasany
. Now, it returns correct types. Congrats!But, I believe there is a small mistake.
SVGGraphics.getSVG
has type of(operatorList: PDFOperatorList, viewport: PageViewport) => Promise<void>
, which I believe is not accurate representation of what this method does. I think it's supposed to be(operatorList: PDFOperatorList, viewport: PageViewport) => Promise<SVGElement>
.The text was updated successfully, but these errors were encountered: