[api-minor] Support custom offsetX/offsetY values in PDFPageProxy.getViewport and PageViewport.clone
#11273
Conversation
…o use a valid rotation angle As can be seen in `PageViewport` only multiples of 90 degrees are really supported by the code, hence the unit-test doesn't really make sense. (Possibly this should be enforced in the API, to avoid surprises, but given that this problem has always existed I'm passing on that for now.)
…y.getViewport` and `PageViewport.clone` There's no good reason, as far as I can tell, to not also support `offsetX`/`offsetY` in addition to e.g. `dontFlip`.
Snuffleupagus
force-pushed
the
getViewport-offsets
branch
from
035bde8
to
681bc9d
Compare
Snuffleupagus
changed the title
offsetX/offsetY values in PDFPageView.getViewport and PageViewport.cloneoffsetX/offsetY values in PDFPageProxy.getViewport and PageViewport.clone
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2dfd800eb681090/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b35f84ab2c41d12/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2dfd800eb681090/output.txt Total script time: 2.59 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/b35f84ab2c41d12/output.txt Total script time: 5.30 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a64cd980226f7fa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a64cd980226f7fa/output.txt Total script time: 1.69 mins Published |
|
Looks good to me; thank you for picking this up! |
|
When does this become available for the npm package, so I can try it? |
|
In the next release. The date for that is not yet determined. |
There's no good reason, as far as I can tell, to not also support
offsetX/offsetYin addition to e.g.dontFlip.Fixes #11239.