Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused wideChars property on Font instances #11719

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

This property was added in PR #1599 (almost eight years ago), but has been unused ever since PR #3674 (six and a half years ago).

This property was added in PR 1599 (almost eight years ago), but has been unused ever since PR 3674 (six and a half years ago).
@Snuffleupagus
Copy link
Collaborator Author

Travis runs npm update as part of the setup, which thus updates packages further than the package-lock.json file in this repository suggests.

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/fdce6fec0787fd8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0fef51393309e87/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/0fef51393309e87/output.txt

Total script time: 1.13 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/fdce6fec0787fd8/output.txt

Total script time: 2.12 mins

  • Lint: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/725d367bc89f583/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/80a311a0e268f62/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/80a311a0e268f62/output.txt

Total script time: 25.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/80a311a0e268f62/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/725d367bc89f583/output.txt

Total script time: 60.00 mins

@timvandermeij timvandermeij merged commit ab2b2ae into mozilla:master Mar 20, 2020
@timvandermeij
Copy link
Contributor

Nice find!

@Snuffleupagus Snuffleupagus deleted the rm-fonts-widechars branch March 20, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants