Implement rendering square/circle annotations without appearance stream #13031
Conversation
timvandermeij
force-pushed
the
annotation-square-circle-no-appearance-stream
branch
from
6e42f37
to
04eb81b
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/df753c0cba08f77/output.txt |
timvandermeij
force-pushed
the
annotation-square-circle-no-appearance-stream
branch
from
04eb81b
to
1dfd84f
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/df753c0cba08f77/output.txt Total script time: 4.06 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9f4e1f34fb6d592/output.txt |
| @@ -2278,6 +2291,43 @@ class SquareAnnotation extends MarkupAnnotation { | |||
| super(parameters); | |||
|
|
|||
| this.data.annotationType = AnnotationType.SQUARE; | |||
|
|
|||
| if (!this.appearance) { | |||
There was a problem hiding this comment.
Just to help me understand the differences between Annotation types:
It seems that a few of existing .... extends MarkupAnnotation-cases only does this when quadPoints is defined, note e.g. HighlightAnnotation, hence I wonder what's different between the various Annotation types here?
There was a problem hiding this comment.
Good question! I looked into the specification and found that the existing annotation types that do the quadpoints check, namely highlight/squiggly/underline/strikethrough, are text markup annotations and those are required to have quadpoints; see https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=411&zoom=auto,-215,424. Circle and square annotations on the other hand are regular markup annotations and for those quadpoints are not defined; see https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=399&zoom=auto,-215,760.
In our implementation we don't make this distinction because for how we work with them this difference is irrelevant. The overview at https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=398&zoom=auto,-215,775 shows which annotation types are markup annotations and it also shows that highlight/squiggly/underline/strikethrough annotations belong to the text markup annotation "subcategory". The reason is that they are always applied to text, whereas squares/circles/other markup annotations are not text-related and can be used anywhere in the document.
Hopefully this helps a bit to clear things up :-)
There was a problem hiding this comment.
Hopefully this helps a bit to clear things up :-)
That's indeed very helpful, thank you!
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9f4e1f34fb6d592/output.txt Total script time: 24.03 mins
Image differences available at: http://54.67.70.0:8877/9f4e1f34fb6d592/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/df45bbaa59535f1/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/df45bbaa59535f1/output.txt Total script time: 28.99 mins
Image differences available at: http://3.101.106.178:8877/df45bbaa59535f1/reftest-analyzer.html#web=eq.log |
timvandermeij
force-pushed
the
annotation-square-circle-no-appearance-stream
branch
from
1dfd84f
to
fa6cebf
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ed1960a6e9f82f6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ed1960a6e9f82f6/output.txt Total script time: 4.19 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c33d10e53b70397/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/ad9f55cecbadbdc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c33d10e53b70397/output.txt Total script time: 24.54 mins
Image differences available at: http://54.67.70.0:8877/c33d10e53b70397/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/ad9f55cecbadbdc/output.txt Total script time: 29.05 mins
Image differences available at: http://3.101.106.178:8877/ad9f55cecbadbdc/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e9e75eee0697748/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f86f895e222babd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e9e75eee0697748/output.txt Total script time: 22.05 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/f86f895e222babd/output.txt Total script time: 26.65 mins
|
timvandermeij
deleted the
annotation-square-circle-no-appearance-stream
branch
Fixes another part of #6810.