Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BiDi protocol for Chrome tests #17962

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Use BiDi protocol for Chrome tests #17962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/integration/freetext_editor_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,6 +2273,7 @@ describe("FreeText Editor", () => {

rect = await getRect(page, getEditorSelector(0));

// Create a new editor.
await page.mouse.click(
rect.x + 5 * rect.width,
rect.y + 5 * rect.height
Expand All @@ -2288,11 +2289,12 @@ describe("FreeText Editor", () => {
`${getEditorSelector(1)} .overlay.enabled`
);

rect = await getRect(page, getEditorSelector(0));
// Select the second editor.
rect = await getRect(page, getEditorSelector(1));

await page.mouse.click(
rect.x + 5 * rect.width,
rect.y + 5 * rect.height
rect.x + 0.5 * rect.width,
rect.y + 0.5 * rect.height
);
await waitForSelectedEditor(page, getEditorSelector(1));

Expand Down
10 changes: 3 additions & 7 deletions test/test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,12 +883,12 @@ async function startBrowser({
}) {
const options = {
product: browserName,
protocol: "cdp",
dumpio: true,
protocol: "webDriverBiDi",
calixteman marked this conversation as resolved.
Show resolved Hide resolved
headless,
dumpio: true,
defaultViewport: null,
ignoreDefaultArgs: ["--disable-extensions"],
// The timeout for individual protocol (CDP) calls should always be lower
// The timeout for individual protocol (BiDi) calls should always be lower
// than the Jasmine timeout. This way protocol errors are always raised in
// the context of the tests that actually triggered them and don't leak
// through to other tests (causing unrelated failures or tracebacks). The
Expand All @@ -911,10 +911,6 @@ async function startBrowser({
}

if (browserName === "firefox") {
// Run tests with the WebDriver BiDi protocol enabled only for Firefox for
// now given that for Chrome further fixes are needed first.
options.protocol = "webDriverBiDi";

options.extraPrefsFirefox = {
// Disable system addon updates.
"extensions.systemAddon.update.enabled": false,
Expand Down