Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ignoreErrors option from the FontFaceObject class #18066

Merged
merged 2 commits into from
May 14, 2024
Merged

Remove the ignoreErrors option from the FontFaceObject class #18066

merged 2 commits into from
May 14, 2024

Commits on May 11, 2024

  1. Use more object destructuring in the "commonobj" handler in the API

    @Snuffleupagus
    Snuffleupagus committed May 11, 2024
    Configuration menu
    Copy the full SHA
    5e50479 View commit details
    Browse the repository at this point in the history

  2. Remove the ignoreErrors option from the FontFaceObject class 

     - The `stopAtErrors` API option, which is the inverse of the "internal" `ignoreErrors` option, is explicitly documented as applying to *parsing* (i.e. the worker-thread) while the `FontFaceObject` class is used during rendering (i.e. the main-thread); see https://github.com/mozilla/pdf.js/blob/b6765403a1b08aa80a21cb0809741875a925ab4d/src/display/api.js#L164-L167

 - A glyph that fails in the `FontRendererFactory`, on the worker-thread, will already cause (overall) parsing to stop when `ignoreErrors === false` hence checking the option on the main-thread as well seems redundant; see https://github.com/mozilla/pdf.js/blob/b6765403a1b08aa80a21cb0809741875a925ab4d/src/core/evaluator.js#L4527-L4533

 - Removing this option simplifies the code, and slightly reduces the number of options that we need to handle in the main-thread code.
    @Snuffleupagus
    Snuffleupagus committed May 11, 2024
    Configuration menu
    Copy the full SHA
    5f6f168 View commit details
    Browse the repository at this point in the history