-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the merge-stream
dependency in favor of the ordered-read-streams
dependency
#18145
Conversation
…reams` dependency The `merge-stream` dependency is no longer maintained and doesn't work in combination with Gulp 5 anymore (for more information refer to gulpjs/gulp#2802 (comment)). Fortunately the Gulp team maintains a drop-in replacement dependency called `ordered-read-streams` with the same API as `merge-stream`. Indeed, running all affected Gulp targets and comparing build artifacts with `diff -r <old> <new>` confirms that no unexpected changes are made. Fixes a part of mozilla#17922.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f7c9f65d9a81e89/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f7c9f65d9a81e89/output.txt Total script time: 1.17 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/dcad3cfcf12ce98/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e8ce4fca671a0c1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/dcad3cfcf12ce98/output.txt Total script time: 27.67 mins
Image differences available at: http://54.241.84.105:8877/dcad3cfcf12ce98/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e8ce4fca671a0c1/output.txt Total script time: 42.83 mins
Image differences available at: http://54.193.163.58:8877/e8ce4fca671a0c1/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
The
merge-stream
dependency is no longer maintained and doesn't work in combination with Gulp 5 anymore (for more information refer to gulpjs/gulp#2802 (comment)).Fortunately the Gulp team maintains a drop-in replacement dependency called
ordered-read-streams
with the same API asmerge-stream
. Indeed, running all affected Gulp targets and comparing build artifacts withdiff -r <old> <new>
confirms that no unexpected changes are made.Fixes a part of #17922.