Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the merge-stream dependency in favor of the ordered-read-streams dependency #18145

Merged
merged 1 commit into from
May 22, 2024

Conversation

timvandermeij
Copy link
Contributor

The merge-stream dependency is no longer maintained and doesn't work in combination with Gulp 5 anymore (for more information refer to gulpjs/gulp#2802 (comment)).

Fortunately the Gulp team maintains a drop-in replacement dependency called ordered-read-streams with the same API as merge-stream. Indeed, running all affected Gulp targets and comparing build artifacts with diff -r <old> <new> confirms that no unexpected changes are made.

Fixes a part of #17922.

…reams` dependency

The `merge-stream` dependency is no longer maintained and doesn't work
in combination with Gulp 5 anymore (for more information refer to
gulpjs/gulp#2802 (comment)).

Fortunately the Gulp team maintains a drop-in replacement dependency
called `ordered-read-streams` with the same API as `merge-stream`.
Indeed, running all affected Gulp targets and comparing build artifacts
with `diff -r <old> <new>` confirms that no unexpected changes are made.

Fixes a part of mozilla#17922.
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f7c9f65d9a81e89/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f7c9f65d9a81e89/output.txt

Total script time: 1.17 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dcad3cfcf12ce98/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e8ce4fca671a0c1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/dcad3cfcf12ce98/output.txt

Total script time: 27.67 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/dcad3cfcf12ce98/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e8ce4fca671a0c1/output.txt

Total script time: 42.83 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/e8ce4fca671a0c1/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@timvandermeij timvandermeij merged commit b7b8e5e into mozilla:master May 22, 2024
9 checks passed
@timvandermeij timvandermeij deleted the merge-stream branch May 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants