Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the regular expression in tweakWebpackOutput to support minified-legacy builds (issue 18290) #18292

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus Snuffleupagus linked an issue Jun 19, 2024 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6390901190a62e4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a46ca35c75c1e4f/output.txt

@nicolo-ribaudo
Copy link
Contributor

Would be it be safer to have an AST-based transform?

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Jun 19, 2024

Would be it be safer to have an AST-based transform?

Of course, assuming that works. (I'm not sure if these webpack-structures are available during babel-plugin-pdfjs-preprocessor.mjs, or if those are added later on.)

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/6390901190a62e4/output.txt

Total script time: 28.49 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/6390901190a62e4/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a46ca35c75c1e4f/output.txt

Total script time: 44.40 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/a46ca35c75c1e4f/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit b7d194f into mozilla:master Jun 19, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Thanks! For now this fixes the issue and the code is shorter, and if it can later be moved to an AST transform that'd be even better.

@Snuffleupagus Snuffleupagus deleted the tweakWebpackOutput-improve-regex branch June 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdfjsLib is not exposed in the minified legacy build
4 participants