Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend GlyphMapForStandardFonts to fix issue 4276 #4716

Merged
merged 1 commit into from
May 1, 2014
Merged

Amend GlyphMapForStandardFonts to fix issue 4276 #4716

merged 1 commit into from
May 1, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

This PR adds more entries in GlyphMapForStandardFonts, in order to fix #4276.
I've checked a number of standard fonts (with the help of TTX) and they all seem to agree on the CID <-> GID mapping.

I expect one text failure, in bug921760.pdf, since the hyphen is currently incorrectly mapped (causing it to be replaced with a rectangle instead). This change also removes #3191 (comment).

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/15bd19520d26ace/output.txt

@timvandermeij
Copy link
Contributor

Confirmed: fixes #4276 and fixes #3191. Really nice!

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/a9fb40b3af0a8de/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/90cbabeed4d58bb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/a9fb40b3af0a8de/output.txt

Total script time: 22.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/a9fb40b3af0a8de/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/90cbabeed4d58bb/output.txt

Total script time: 25.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/90cbabeed4d58bb/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

Looks good, thank you for the patch.

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8af084873b8c76f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fc4a7b284cf9709/output.txt

yurydelendik added a commit that referenced this pull request May 1, 2014
Amend GlyphMapForStandardFonts to fix issue 4276
@yurydelendik yurydelendik merged commit 693152e into mozilla:master May 1, 2014
@yurydelendik yurydelendik mentioned this pull request May 1, 2014
@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/fc4a7b284cf9709/output.txt

Total script time: 22.57 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/8af084873b8c76f/output.txt

Total script time: 25.95 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-ascii chars are rendered incorrectly in one PDF document
4 participants