[CIDFontType2] Map characters missing in toUnicode to the private use area (bug 1028735 and issue 4881) #5017
Conversation
Cache a constant length and replace one usage of |in| with a comparison against undefined.
Replace a couple of |in| checks with comparisons against undefined.
Snuffleupagus
changed the title
… area (bug 1028735 and issue 4881)
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c054e11c342164e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f608ad2cacf282a/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/c054e11c342164e/output.txt Total script time: 0.10 mins |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/f608ad2cacf282a/output.txt Total script time: 0.97 mins
Image differences available at: http://107.22.172.223:8877/f608ad2cacf282a/reftest-analyzer.html#web=eq.log |
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/00b3dfbdf4dc3a0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/00b3dfbdf4dc3a0/output.txt Total script time: 0.94 mins Published
|
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a625dfa27744f2b/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/a625dfa27744f2b/output.txt Total script time: 2.78 mins
Image differences available at: http://107.22.172.223:8877/a625dfa27744f2b/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/188c6e52948961a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3286e05a916ee16/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3286e05a916ee16/output.txt Total script time: 21.42 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/188c6e52948961a/output.txt Total script time: 36.44 mins
Image differences available at: http://107.21.233.14:8877/188c6e52948961a/reftest-analyzer.html#web=eq.log |
|
/botio-linux makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8eab84f86d2c202/output.txt |
[CIDFontType2] Map characters missing in toUnicode to the private use area (bug 1028735 and issue 4881)
|
Thank you for the patch! |
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/2edfa6f4ead99aa/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8eab84f86d2c202/output.txt Total script time: 36.85 mins
|
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1028735.
Fixes #4881.
Please note: The PDF file linked in the bug has been changed on the server, and the new file isn't affected by this issue, however I still think it makes sense to fix this since it's a regression.
Also, the test-case included here is obviously created from the previous (broken) version of the PDF file.
(Depends on PR #5014.)
Edit: Given that this PR basically reverts one aspect of
CIDFontType2font parsing to the state prior to PR #4259, I'm not sure if this patch is the ideal way to fix these regressions.Even though this PR does fix two regressions, there is obviously a risk that it can regress other PDF files (where we currently don't have sufficient test coverage).