Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MMType1 fonts with embedded font files #5308

Merged
merged 1 commit into from
Sep 25, 2014
Merged

Add support for MMType1 fonts with embedded font files #5308

merged 1 commit into from
Sep 25, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

According to the PDF specification (see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#page=265):

If the font program for a multiple master font instance is embedded in the PDF file, it shall be an ordinary Type 1 font program, not a multiple master font program. This font program is called a snapshot of the multiple master font instance that incorporates the chosen values of the design coordinates.

Based on the above, I don't think that we actually need to do anything to be able to support PDF files with MMType1 fonts with embedded font files. In all the cases of MMType1 fonts that I've come across, all the font properties used are really just the ones used for normal Type1 fonts.

Fixes #1381.
Fixes #4500.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=794222.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=849634.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1069315.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d06700bfc8e997e/output.txt

@timvandermeij
Copy link
Contributor

I agree. See also the comments over at https://issues.apache.org/jira/browse/PDFBOX-1896.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/dea947e5fcf73f9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/049775624306d71/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/049775624306d71/output.txt

Total script time: 2.89 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/049775624306d71/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/dea947e5fcf73f9/output.txt

Total script time: 22.82 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@CodingFabian
Copy link
Contributor

looks good to me

@timvandermeij
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://107.22.172.223:8877/11f055c8bc3dc1b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/11f055c8bc3dc1b/output.txt

Total script time: 2.99 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/11f055c8bc3dc1b/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2254185810542f5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/2254185810542f5/output.txt

Total script time: 21.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/1d246c853f3a7b8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/220720bc051a457/output.txt

yurydelendik added a commit that referenced this pull request Sep 25, 2014
Add support for MMType1 fonts with embedded font files
@yurydelendik yurydelendik merged commit 4189c78 into mozilla:master Sep 25, 2014
@yurydelendik
Copy link
Contributor

Thank you for the patch

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/1d246c853f3a7b8/output.txt

Total script time: 19.79 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/220720bc051a457/output.txt

Total script time: 22.49 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the fonts-mmtype1 branch September 25, 2014 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing letters in equations Font not displaying (CronosMM)
5 participants